about summary refs log tree commit diff
path: root/tvix/eval
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-03-08T21·04+0200
committerclbot <clbot@tvl.fyi>2024-03-09T05·48+0000
commitbd1def3ec4dce82fb069815ab5de29f359bae78d (patch)
treeab4089988dfcebf9adea2a95f8119223a9542e28 /tvix/eval
parent4e78de739327c33f37dad510875065d1ed57e2e8 (diff)
fix(tvix/store/grpc/pathinfo): skip_all fields, handle errors r/7661
request only contains the outer metadata wrapping, and that's not too
interesting:

> Request { metadata: MetadataMap { headers: {"content-type":
> "application/grpc", "user-agent": "grpc-go/1.60.1", "te": "trailers",
> "grpc-accept-encoding": "gzip"} }, message: Streaming, extensions:
> Extensions }

Drop these fields for now, and rely on the underlying implementations to
add instrumentation for the application-specific fields.

Also, ensure we handle all error cases properly, and log them. We
don't use `err` from instrument, as that'd also log an error on
`Status::not_found`.

Change-Id: Id1b983cb8b059c148c8a376f8802a1d28c59ba97
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11103
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/eval')
0 files changed, 0 insertions, 0 deletions