diff options
| author | Vincent Ambo <mail@tazj.in> | 2023-01-21T11·10+0300 |
|---|---|---|
| committer | tazjin <tazjin@tvl.su> | 2023-01-22T19·39+0000 |
| commit | 8513a58b37ffb032a621fb25d5952f6d4df27872 (patch) | |
| tree | 92e719b0134c62066ee5e25e98a781990bbec2ec /tvix/eval | |
| parent | 59c3383b10dc9fb356102164eddf40294c09dae6 (diff) | |
docs(tvix/eval): update some outdated comments r/5734
These don't apply anymore since the "antidote-CL". Change-Id: I40ee73ef43d44bbfc650a8fe6c2b33263dd06959 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7890 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/eval')
| -rw-r--r-- | tvix/eval/src/compiler/mod.rs | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index a552f50b5ebe..99e1d4c53c6c 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -46,10 +46,9 @@ pub struct CompilationOutput { pub warnings: Vec<EvalWarning>, pub errors: Vec<Error>, - // This field must outlive the rc::Weak reference which breaks - // the builtins -> import -> builtins reference cycle. - // - // TODO: ensure through compiler + // This field must outlive the rc::Weak reference which breaks the + // builtins -> import -> builtins reference cycle. For this + // reason, it must be passed to the VM. pub globals: Rc<GlobalsMap>, } @@ -1266,10 +1265,6 @@ pub fn prepare_globals( // builtins contain themselves (`builtins.builtins`), which we // can resolve by manually constructing a suspended thunk that // dereferences the same weak pointer as above. - // - // This is an inefficient hack, but *if* anyone was to use - // `builtins.builtins`, it would only happen once as the thunk - // is then resolved. let weak_globals = weak.clone(); builtins.insert( "builtins", |