diff options
| author | Vincent Ambo <mail@tazj.in> | 2022-09-24T13·38+0300 |
|---|---|---|
| committer | tazjin <tazjin@tvl.su> | 2022-09-29T11·47+0000 |
| commit | e31f8f735f72fa1d71f4a030ff778ebe640e9fb1 (patch) | |
| tree | 086bb567d76e2d89e789b6b9cf1d37703cc63834 /tvix/eval/src | |
| parent | d54aeb1f2055bdac05cb62ab30b6c63dc86a78e0 (diff) | |
chore(tvix/eval): fix all current clippy lints r/4991
Change-Id: I28d6af8cb408f8427a75d30b9120aaa809a1ea40 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6784 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src')
| -rw-r--r-- | tvix/eval/src/builtins/mod.rs | 4 | ||||
| -rw-r--r-- | tvix/eval/src/builtins/versions.rs | 2 | ||||
| -rw-r--r-- | tvix/eval/src/compiler/mod.rs | 4 | ||||
| -rw-r--r-- | tvix/eval/src/errors.rs | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 80c1fac2c0..45630819e1 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -59,7 +59,7 @@ fn pure_builtins() -> Vec<Builtin> { |args, vm| arithmetic_op!(&*args[0].force(vm)?, &*args[1].force(vm)?, +), ), Builtin::new("abort", &[true], |args, _| { - return Err(ErrorKind::Abort(args[0].to_str()?.to_string())); + Err(ErrorKind::Abort(args[0].to_str()?.to_string())) }), Builtin::new("attrNames", &[true], |args, _| { let xs = args[0].to_attrs()?; @@ -313,7 +313,7 @@ fn pure_builtins() -> Vec<Builtin> { } }), Builtin::new("throw", &[true], |args, _| { - return Err(ErrorKind::Throw(args[0].to_str()?.to_string())); + Err(ErrorKind::Throw(args[0].to_str()?.to_string())) }), // coerce_to_string forces for us Builtin::new("toString", &[false], |args, vm| { diff --git a/tvix/eval/src/builtins/versions.rs b/tvix/eval/src/builtins/versions.rs index 9da7b52ab1..79fb82b868 100644 --- a/tvix/eval/src/builtins/versions.rs +++ b/tvix/eval/src/builtins/versions.rs @@ -18,7 +18,7 @@ impl PartialOrd for VersionPart<'_> { } impl Ord for VersionPart<'_> { - fn cmp(self: &Self, other: &Self) -> Ordering { + fn cmp(&self, other: &Self) -> Ordering { match (self, other) { (VersionPart::Number(s1), VersionPart::Number(s2)) => { // Note: C++ Nix uses `int`, but probably doesn't make a difference diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index dab91a7f56..bae58434b3 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -553,7 +553,7 @@ impl Compiler<'_> { } // Push the set onto the stack - self.compile(slot, set.clone()); + self.compile(slot, set); // Compile each key fragment and emit access instructions. // @@ -604,7 +604,7 @@ impl Compiler<'_> { path: ast::Attrpath, default: ast::Expr, ) { - self.compile(slot, set.clone()); + self.compile(slot, set); let mut jumps = vec![]; for fragment in path.attrs() { diff --git a/tvix/eval/src/errors.rs b/tvix/eval/src/errors.rs index 7ec43abb85..822ebdbc8c 100644 --- a/tvix/eval/src/errors.rs +++ b/tvix/eval/src/errors.rs @@ -162,7 +162,7 @@ impl Error { format!("list index '{}' is out of bounds", index) } - ErrorKind::TailEmptyList => format!("'tail' called on an empty list"), + ErrorKind::TailEmptyList => "'tail' called on an empty list".to_string(), ErrorKind::TypeError { expected, actual } => format!( "expected value of type '{}', but found a '{}'", |