feat(tvix/eval): skip & warn for useless parenthesis r/5607

Change-Id: I567ca0682012b9d09f1217e57a104ac5671f8d82
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7771
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Reviewed-by: flokli <flokli@flokli.de>

1 files changed, 6 insertions, 0 deletions

diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs
index cfe5044a8c..26efd24d1e 100644
--- a/tvix/eval/src/warnings.rs
+++ b/tvix/eval/src/warnings.rs
@@ -17,6 +17,7 @@ pub enum WarningKind {
     DeadCode,
     EmptyInherit,
     EmptyLet,
+    UselessParens,
 
     /// Tvix internal warning for features triggered by users that are
     /// not actually implemented yet, but do not cause runtime failures.
@@ -105,6 +106,10 @@ impl EvalWarning {
                 format!("this `let`-expression contains no bindings")
             }
 
+            WarningKind::UselessParens => {
+                format!("these parenthesis can be removed")
+            }
+
             WarningKind::NotImplemented(what) => {
                 format!("feature not yet implemented in tvix: {}", what)
             }
@@ -125,6 +130,7 @@ impl EvalWarning {
             WarningKind::DeadCode => "W008",
             WarningKind::EmptyInherit => "W009",
             WarningKind::EmptyLet => "W010",
+            WarningKind::UselessParens => "W011",
 
             WarningKind::NotImplemented(_) => "W999",
         }