diff options
| author | Aspen Smith <root@gws.fyi> | 2024-02-01T17·28-0500 |
|---|---|---|
| committer | aspen <root@gws.fyi> | 2024-02-02T16·16+0000 |
| commit | 5f0f4ea3746d6107839454bb5f4967d8757f5bb8 (patch) | |
| tree | e618eca064cb7e263c58136f2c07b1dead63f49c /tvix/eval/src/vm/generators.rs | |
| parent | 4c5d9fa356bcb6dcd746129dde934412b44fdd35 (diff) | |
refactor(tvix/eval): Box Value::String r/7467
NixString is *quite* large - like 80 bytes - because of the extra capacity value for BString and because of the context. We want to keep Value small since we're passing it around a lot, so let's box the NixString inside Value::String to save on some memory, and make cloning ostensibly a little cheaper Change-Id: I343c8b4e7f61dc3dcbbaba4382efb3b3e5bbabb2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10729 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/src/vm/generators.rs')
| -rw-r--r-- | tvix/eval/src/vm/generators.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tvix/eval/src/vm/generators.rs b/tvix/eval/src/vm/generators.rs index 3d2fd9d266c7..e5468fb06d4a 100644 --- a/tvix/eval/src/vm/generators.rs +++ b/tvix/eval/src/vm/generators.rs @@ -436,7 +436,7 @@ where }) .with_span(&span, self)?; - message = VMResponse::Value(Value::String(content.into())) + message = VMResponse::Value(content.into()) } VMRequest::PathExists(path) => { @@ -607,7 +607,7 @@ pub async fn request_string_coerce( kind: CoercionKind, ) -> Result<NixString, CatchableErrorKind> { match val { - Value::String(s) => Ok(s), + Value::String(s) => Ok(*s), _ => match co.yield_(VMRequest::StringCoerce(val, kind)).await { VMResponse::Value(Value::Catchable(c)) => Err(c), VMResponse::Value(value) => Ok(value |