diff options
| author | Vincent Ambo <tazjin@tvl.su> | 2024-02-20T11·09+0700 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-02-20T12·33+0000 |
| commit | 20833656aee4aaefdd83e7beb141a5e03f8c956d (patch) | |
| tree | 454af1a374146379cc4c4082d231e62c7bf7f52b /tvix/eval/src/value | |
| parent | d9565a4d0af3bffd735a77aa6f1fd0ec0e03b14a (diff) | |
fix(tvix/eval): propagate catchable errors at the top of an eval r/7577
(Re-)Adds an error variant that wraps a catchable error kind, which is used for returning the result of an evaluation. Previously this would return the internal catchable value, which would lead to panics if users tried to use these. Somehow this was missed; I think we need error output tests. Change-Id: Id6e24aa2ce4ea4358a29b2e1cf4a6749986baf8c Reviewed-on: https://cl.tvl.fyi/c/depot/+/10991 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/eval/src/value')
| -rw-r--r-- | tvix/eval/src/value/mod.rs | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/eval/src/value/mod.rs b/tvix/eval/src/value/mod.rs index 165bdac597ad..095bc269d497 100644 --- a/tvix/eval/src/value/mod.rs +++ b/tvix/eval/src/value/mod.rs @@ -84,6 +84,7 @@ pub enum Value { FinaliseRequest(bool), #[serde(skip)] + // TODO(tazjin): why is this in a Box? Catchable(Box<CatchableErrorKind>), } |