about summary refs log tree commit diff
path: root/tvix/eval/src/value/mod.rs
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-08-26T23·59+0300
committertazjin <tazjin@tvl.su>2022-09-04T17·40+0000
commit7c2fdefcd8ff693be1afd15a08958f09d07a0e91 (patch)
tree045f19e593878fc362e9fa70601c42859ff56d32 /tvix/eval/src/value/mod.rs
parent26acc2e636245d307c99201de6891da54ac1dbc5 (diff)
fix(tvix/eval): pop with stack immediately after processing body r/4633
Instead of tying the popping of the with stack to scope depth, clean
up the stack immediately after processing a with body.

The previous behaviour was actually incorrect, as it would leave
things on the with-stack longer than they were supposed to be there.
This could lead to false positive resolutions in some situations
involving closures.

Change-Id: I7b0638557503f1f71eb602e3d5ff193cdfcb67cc
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6297
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/src/value/mod.rs')
0 files changed, 0 insertions, 0 deletions