diff options
| author | Aspen Smith <root@gws.fyi> | 2024-02-01T17·28-0500 |
|---|---|---|
| committer | aspen <root@gws.fyi> | 2024-02-02T16·16+0000 |
| commit | 5f0f4ea3746d6107839454bb5f4967d8757f5bb8 (patch) | |
| tree | e618eca064cb7e263c58136f2c07b1dead63f49c /tvix/eval/src/value/arbitrary.rs | |
| parent | 4c5d9fa356bcb6dcd746129dde934412b44fdd35 (diff) | |
refactor(tvix/eval): Box Value::String r/7467
NixString is *quite* large - like 80 bytes - because of the extra capacity value for BString and because of the context. We want to keep Value small since we're passing it around a lot, so let's box the NixString inside Value::String to save on some memory, and make cloning ostensibly a little cheaper Change-Id: I343c8b4e7f61dc3dcbbaba4382efb3b3e5bbabb2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10729 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/src/value/arbitrary.rs')
| -rw-r--r-- | tvix/eval/src/value/arbitrary.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tvix/eval/src/value/arbitrary.rs b/tvix/eval/src/value/arbitrary.rs index d894aa3fe937..a2e8cb899c92 100644 --- a/tvix/eval/src/value/arbitrary.rs +++ b/tvix/eval/src/value/arbitrary.rs @@ -91,7 +91,7 @@ fn leaf_value() -> impl Strategy<Value = Value> { any::<bool>().prop_map(Bool), any::<i64>().prop_map(Integer), any::<f64>().prop_map(Float), - any::<NixString>().prop_map(String), + any::<Box<NixString>>().prop_map(String), any::<OsString>().prop_map(|s| Path(PathBuf::from(s).into_boxed_path())), ] } |