diff options
author | Griffin Smith <root@gws.fyi> | 2022-10-23T17·24-0400 |
---|---|---|
committer | grfn <grfn@gws.fyi> | 2022-10-24T13·44+0000 |
commit | 5bd0e723c13b8a41bfba442bd8ef5351e31099e6 (patch) | |
tree | dc258cedc3fbe2f8e8c51e8e40fdd0aa93bf8618 /tvix/eval/src/upvalues.rs | |
parent | 7b3bda9e089fe9de2d28a28f64ef8532abb3ac9c (diff) |
refactor(tvix/eval): Implement value comparison with a method r/5193
Rather than implementing all of the interesting semantics of value comparison with a macro bound to the VM, implement the bulk of the logic with a method on Value itself that returns an Ordering, and then use the macro to implement the comparison against that Ordering. This has no functional change, but paves the way to implementing lexicographic comparison of list values, which is supported in the latest version of upstream nix. Change-Id: I8af1a020b41577021af5939f5edc160c407d4a9e Reviewed-on: https://cl.tvl.fyi/c/depot/+/7069 Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/eval/src/upvalues.rs')
0 files changed, 0 insertions, 0 deletions