about summary refs log tree commit diff
path: root/tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-08-25T11·23+0300
committertazjin <tazjin@tvl.su>2022-09-03T00·47+0000
commit39b01c302937fe3e91c15758b520c3ecc5379c7b (patch)
treecff95e288671533056fcea8a62e3fe620b77ef6d /tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix
parent265393301e2b59659a0a5db15e42bc668d0c7c68 (diff)
fix(tvix/eval): correctly escape `${` in strings r/4607
Without this escape, it is possible for Nix to produce escaped
representations which are not literal Nix values again.

This was fixed in upstream Nix in
https://github.com/NixOS/nix/pull/4012 (though only for eval, not in
the REPL) and the updated test is picked from upstream after that commit.

Because we run the C++ Nix tests against our test suite as well, this
also bumps our custom Nix 2.3 to a commit that includes the
cherry-picked fix from the PR above.

Change-Id: I478547ade65f655c606ec46f7143932064192283
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6271
Reviewed-by: grfn <grfn@gws.fyi>
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix')
-rw-r--r--tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix1
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix b/tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix
new file mode 100644
index 000000000000..08951d7637a6
--- /dev/null
+++ b/tvix/eval/src/tests/tvix_tests/identity-dollar-escape.nix
@@ -0,0 +1 @@
+"\${foobar}"