about summary refs log tree commit diff
path: root/tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-08-16T11·40+0300
committertazjin <tazjin@tvl.su>2022-08-31T22·42+0000
commit0b51d6308171a165fc26005e67c9e9c6f0c59c1f (patch)
treea7ecb9a1250c482b4f536e5b26d5592b202ea8de /tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix
parent75ba7c01200650ad76658da948f39e970cefb5c2 (diff)
refactor(tvix/eval): simplify `let ... in ...` before recursion r/4560
While full recursion through thunking is not available, there are
actually incorrect behaviours introduced by declaring before
binding (example in the newly introduced test).

This commit simplifies the implementation to avoid this issue, and
also because I intend to explore a bit more how far we can get in non
left-to-right bindings *without* introducing thunks immediately.

Change-Id: I21fd3007ac3946570639772d7d624d70bd209958
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6226
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Reviewed-by: grfn <grfn@gws.fyi>
Diffstat (limited to 'tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix')
-rw-r--r--tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix7
1 files changed, 7 insertions, 0 deletions
diff --git a/tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix b/tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix
new file mode 100644
index 000000000000..caaa20211928
--- /dev/null
+++ b/tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix
@@ -0,0 +1,7 @@
+let
+  a = let
+    b = 1;
+    c = 2;
+  in b + c;
+  b = 4;
+in a + b