diff options
| author | sterni <sternenseemann@systemli.org> | 2023-12-13T13·06+0100 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2023-12-14T02·59+0000 |
| commit | a30dd0905a08a78bb0573136064dd334a0567f6a (patch) | |
| tree | d13087c5144d46b14f81949e7ade7f43e2ad704c /tvix/eval/src/tests/tvix_tests/eval-okay-fromjson-escapes.nix | |
| parent | 8b0047e2773586baba37cc2e45c4a3b73c41c50a (diff) | |
fix(tvix/eval): determine meaning of `+` exprs based on first type r/7217
This matches the behavior of C++ Nix more closely where the decision is made based on the first type based to ExprConcatStrings: https://github.com/NixOS/nix/blob/1f93fa2ed29ff0ba92bfa58995232668187fb0d0/src/libexpr/eval.cc#L1967-L2025 Note that this doesn't make a difference in any successful evaluation (at least to my knowledge), but ensures that our error messages will match C++ Nix more closely, e.g. in the case of `1 + "string"`. Change-Id: I8059930788f9c8d98baf98e3d93d8a060ef961f2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10360 Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: Adam Joseph <adam@westernsemico.com>
Diffstat (limited to 'tvix/eval/src/tests/tvix_tests/eval-okay-fromjson-escapes.nix')
0 files changed, 0 insertions, 0 deletions