diff options
author | sterni <sternenseemann@systemli.org> | 2022-09-12T16·03+0200 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2022-09-13T22·06+0000 |
commit | 162e21f2bb326960770ed55ee44170b924c72fd8 (patch) | |
tree | f7dbe91690d2f2a11507e9065aa093a214963a15 /tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-lhs.nix | |
parent | 7e625afc5973b3d3ff08598fb9e513aaf1412e89 (diff) |
fix(tvix/eval): force left argument of `?` before checking for attrs r/4849
OpAttrsIsSet and OpAttrsTrySelect will fail silently if the attribute set value on the stack is actually a thunk, so we need to make sure to force at every step of the way. Emitting the force instructions in the compiler because it is easier to add, but maybe the VM should do this when handling the relevant opcodes? Comments welcome. Change-Id: I65c5ef348d59b2d07c9bb06abb24f9f3e6a0fdb2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6540 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-lhs.nix')
0 files changed, 0 insertions, 0 deletions