diff options
| author | Griffin Smith <root@gws.fyi> | 2022-10-23T17·50-0400 |
|---|---|---|
| committer | tazjin <tazjin@tvl.su> | 2022-10-29T14·04+0000 |
| commit | 3412ae495661e8073075bbb8c24ee0098ca2bede (patch) | |
| tree | 9fa4775f7b059f855ae29e9aa895053bce8236a2 /tvix/eval/src/tests/nix_tests/notyetpassing | |
| parent | d0a836b0e1ee1034144d1e5b71df6ab285c8450e (diff) | |
feat(tvix/eval): Implement builtins.sort r/5222
This is a bit tricky because the comparator can throw errors, so we need to propagate them out if they exist and try to avoid sorting forever by returning a reasonable ordering in this case (as short-circuiting is not available). Co-Authored-By: Vincent Ambo <tazjin@tvl.su> Change-Id: Icae1d30f43ec1ae64b2ba51e73ee467605686792 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7072 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/src/tests/nix_tests/notyetpassing')
| -rw-r--r-- | tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.exp | 1 | ||||
| -rw-r--r-- | tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.nix | 20 |
2 files changed, 0 insertions, 21 deletions
diff --git a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.exp b/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.exp deleted file mode 100644 index 899119e20e..0000000000 --- a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.exp +++ /dev/null @@ -1 +0,0 @@ -[ [ 42 77 147 249 483 526 ] [ 526 483 249 147 77 42 ] [ "bar" "fnord" "foo" "xyzzy" ] [ { key = 1; value = "foo"; } { key = 1; value = "fnord"; } { key = 2; value = "bar"; } ] [ [ ] [ ] [ 1 ] [ 1 4 ] [ 1 5 ] [ 1 6 ] [ 2 ] [ 2 3 ] [ 3 ] [ 3 ] ] ] diff --git a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.nix b/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.nix deleted file mode 100644 index 50aa78e403..0000000000 --- a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.nix +++ /dev/null @@ -1,20 +0,0 @@ -with builtins; - -[ (sort lessThan [ 483 249 526 147 42 77 ]) - (sort (x: y: y < x) [ 483 249 526 147 42 77 ]) - (sort lessThan [ "foo" "bar" "xyzzy" "fnord" ]) - (sort (x: y: x.key < y.key) - [ { key = 1; value = "foo"; } { key = 2; value = "bar"; } { key = 1; value = "fnord"; } ]) - (sort lessThan [ - [ 1 6 ] - [ ] - [ 2 3 ] - [ 3 ] - [ 1 5 ] - [ 2 ] - [ 1 ] - [ ] - [ 1 4 ] - [ 3 ] - ]) -] |