about summary refs log tree commit diff
path: root/tvix/eval/src/opcode.rs
diff options
context:
space:
mode:
authorAdam Joseph <adam@westernsemico.com>2022-10-25T09·16-0700
committerAdam Joseph <adam@westernsemico.com>2022-11-05T21·58+0000
commitc096152953d7178566f8ae53b63154b5f2bbb177 (patch)
tree7e7649bac60cd446adf6079e7ffaf492e137eee4 /tvix/eval/src/opcode.rs
parent8240b2959e47a38cc946d56c7514f15510305f57 (diff)
refactor(tvix/eval): rename Opcode::DataLocalIdx to DataStackIdx r/5250
It is very confusing that this opcode is called DataLocalIdx, but it
carries a StackIdx rather than a LocalIdx.  It seems like this
really ought to be called DataStackIdx, but maybe I've
misunderstood; if so please explain it to me.

Change-Id: I91f6ffa759412beef0b91d3c19ec0d873fe51b99
Signed-off-by: Adam Joseph <adam@westernsemico.com>
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7088
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src/opcode.rs')
-rw-r--r--tvix/eval/src/opcode.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/tvix/eval/src/opcode.rs b/tvix/eval/src/opcode.rs
index 9c7ccb8d19d0..e05e91087a6f 100644
--- a/tvix/eval/src/opcode.rs
+++ b/tvix/eval/src/opcode.rs
@@ -172,7 +172,7 @@ pub enum OpCode {
     //
     // It is illegal for a `Data*` opcode to appear anywhere else.
     /// Populate a static upvalue by copying from the stack immediately.
-    DataLocalIdx(StackIdx),
+    DataStackIdx(StackIdx),
     /// Populate a static upvalue of a thunk by copying it the stack, but do
     /// when the thunk is finalised (by OpFinalise) rather than immediately.
     DataDeferredLocal(StackIdx),