diff options
| author | Griffin Smith <grfn@gws.fyi> | 2022-10-13T03·53-0400 |
|---|---|---|
| committer | tazjin <tazjin@tvl.su> | 2022-10-17T11·29+0000 |
| commit | 2a3d49810482b36de9f2d3087e5064545183dbb3 (patch) | |
| tree | 9cce6ac0209ad046f2549b15041d89b5faa94c48 /tvix/eval/src/opcode.rs | |
| parent | e63d14419f5cc2ea1f0d9e9221062c2c8d40fe31 (diff) | |
feat(tvix/eval): Validate closed formals r/5154
Validate "closed formals" (formal parameters without an ellipsis) via a new ValidateClosedFormals op, which checks the arguments (in an attr set at the top of the stack) against the formal parameters on the Lambda in the current frame, and returns a new UnexpectedArgument error (including the span of the formals themselves!!) if any arguments aren't allowed Change-Id: Idcc47a59167a83be1832a6229f137d84e426c56c Reviewed-on: https://cl.tvl.fyi/c/depot/+/7002 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src/opcode.rs')
| -rw-r--r-- | tvix/eval/src/opcode.rs | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tvix/eval/src/opcode.rs b/tvix/eval/src/opcode.rs index ee1684d7cf..6b2783716c 100644 --- a/tvix/eval/src/opcode.rs +++ b/tvix/eval/src/opcode.rs @@ -98,6 +98,12 @@ pub enum OpCode { OpAttrsTrySelect, OpHasAttr, + /// Throw an error if the attribute set at the top of the stack has any attributes + /// other than those listed in the formals of the current lambda + /// + /// Panics if the current frame is not a lambda with formals + OpValidateClosedFormals, + // `with`-handling OpPushWith(StackIdx), OpPopWith, |