refactor(tvix/eval): store spans instead of nodes in Warning/Error r/4737

Another step towards being able to report accurate errors. The codemap
spans contain strictly more accessible information, as they now retain
information about which input file something came from.

This required some shuffling around in the compiler to thread all the
right information to the right places.

Change-Id: I18ccfb20f07b0c33e1c4f51ca00cd09f7b2d19c6
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6404
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI

1 files changed, 2 insertions, 2 deletions

diff --git a/tvix/eval/src/errors.rs b/tvix/eval/src/errors.rs
index 32d37d78156d..aced6f6a5571 100644
--- a/tvix/eval/src/errors.rs
+++ b/tvix/eval/src/errors.rs
@@ -52,13 +52,13 @@ pub enum ErrorKind {
 
 #[derive(Clone, Debug)]
 pub struct Error {
-    pub node: Option<rnix::SyntaxNode>,
     pub kind: ErrorKind,
+    pub span: Option<codemap::Span>,
 }
 
 impl From<ErrorKind> for Error {
     fn from(kind: ErrorKind) -> Self {
-        Error { node: None, kind }
+        Error { span: None, kind }
     }
 }