about summary refs log tree commit diff
path: root/tvix/eval/src/errors.rs
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2022-09-06T21·33-0700
committerclbot <clbot@tvl.fyi>2022-09-19T00·51+0000
commit2fe18e44860ad97a88d488590c40cf610a274c1d (patch)
tree327fc1ba435528ba944efe0e9d99bd0b96a9edc3 /tvix/eval/src/errors.rs
parent0c75ce2d3d1cf806a9c6330619928739a6ffe98a (diff)
feat(tvix/eval): Support builtins.substring r/4916
Nix's `builtins.substring`:
- doesn't accept negative indexes for `beg` or `end`. Compare the error messages
  for:
  - `builtins.substring -3  5 "testing"`
  - `builtins.substring  3 -5 "testing"`
  - `builtins.substring -3 -5 "testing"`
- returns an empty string when `beg >= end`
- allows `end` to exceed the length of the input string

Change-Id: I83af7a099d81b6d537ebe5029d946c7031cb7113
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6555
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src/errors.rs')
-rw-r--r--tvix/eval/src/errors.rs13
1 files changed, 13 insertions, 0 deletions
diff --git a/tvix/eval/src/errors.rs b/tvix/eval/src/errors.rs
index 1b8f58356cab..6331ee64be1c 100644
--- a/tvix/eval/src/errors.rs
+++ b/tvix/eval/src/errors.rs
@@ -80,6 +80,11 @@ pub enum ErrorKind {
     /// An error occurred when parsing an integer
     ParseIntError(ParseIntError),
 
+    /// A negative integer was used as a value representing length.
+    NegativeLength {
+        length: i64,
+    },
+
     /// Tvix internal warning for features triggered by users that are
     /// not actually implemented yet, and without which eval can not
     /// proceed.
@@ -213,6 +218,13 @@ to a missing value in the attribute set(s) included via `with`."#,
                 format!("invalid integer: {}", err)
             }
 
+            ErrorKind::NegativeLength { length } => {
+                format!(
+                    "cannot use a negative integer, {}, for a value representing length",
+                    length
+                )
+            }
+
             ErrorKind::NotImplemented(feature) => {
                 format!("feature not yet implemented in Tvix: {}", feature)
             }
@@ -244,6 +256,7 @@ to a missing value in the attribute set(s) included via `with`."#,
             ErrorKind::IndexOutOfBounds { .. } => "E019",
             ErrorKind::NotAnAbsolutePath(_) => "E020",
             ErrorKind::ParseIntError(_) => "E021",
+            ErrorKind::NegativeLength { .. } => "E022",
             ErrorKind::NotImplemented(_) => "E999",
         }
     }