about summary refs log tree commit diff
path: root/tvix/eval/src/compiler/spans.rs
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-09-17T23·52+0300
committertazjin <tazjin@tvl.su>2022-09-18T21·12+0000
commit0e5baae7ad16ca2a5a70ba34d922cabcaa68d45e (patch)
tree02efc5d294da14df71e8bebc93de97a5d1d2835b /tvix/eval/src/compiler/spans.rs
parent5dd5c7e254f01f96a2ddfcf2c163c08833ec0061 (diff)
refactor(tvix/eval): clone the Arc<codemap::File> for the compiler r/4907
This disconnects ownership of the `File` reference in a compiler from
the calling scope, which is required for when we implement `import`.

`import` will need to carry an `Rc<RefCell<CodeMap>>` (or maybe, in
the future, Arc) to give us the ability to add new detected code
files at runtime.

Note that the choice of `Arc` over `Rc` here is not ours - it's the
codemap crate's.

Change-Id: I3aeca4ffc167acbd1701846a332d93550b56ba7d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6630
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
Diffstat (limited to 'tvix/eval/src/compiler/spans.rs')
-rw-r--r--tvix/eval/src/compiler/spans.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/tvix/eval/src/compiler/spans.rs b/tvix/eval/src/compiler/spans.rs
index a972a17eddb3..6c11961e0eae 100644
--- a/tvix/eval/src/compiler/spans.rs
+++ b/tvix/eval/src/compiler/spans.rs
@@ -77,8 +77,8 @@ expr_to_span!(ast::Str);
 expr_to_span!(ast::UnaryOp);
 expr_to_span!(ast::With);
 
-impl Compiler<'_, '_> {
+impl Compiler<'_> {
     pub(super) fn span_for<S: ToSpan>(&self, to_span: &S) -> Span {
-        to_span.span_for(self.file)
+        to_span.span_for(&self.file)
     }
 }