diff options
| author | Vincent Ambo <mail@tazj.in> | 2022-09-11T21·41+0300 |
|---|---|---|
| committer | tazjin <tazjin@tvl.su> | 2022-09-16T18·02+0000 |
| commit | 6cc9d298aababe8c2404edef195175d523833006 (patch) | |
| tree | 91c0ff2fbacaad4004f740ed10bc69c9db23ab10 /tvix/eval/src/compiler/mod.rs | |
| parent | 4b1fb8868ddefb9bc4402c3f819ccd8cf4a3ec42 (diff) | |
refactor(tvix/eval): explicitly construct attrs in phases r/4872
This makes the phases of attribute set construction that Nix has very explicit (inherits, static keys, dynamic keys). This change focuses on the split between dynamic/static keys by collecting all dynamic ones while compiling the static ones, and then phasing them in afterwards. It's possible we also need to do some additional splitting inside of the inherits. Change-Id: Icae782e2a5c106e3ce0831dda47ed81c923c0a42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6530 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/eval/src/compiler/mod.rs')
| -rw-r--r-- | tvix/eval/src/compiler/mod.rs | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index 15ff0ea309d3..4a5966ae83a8 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -1257,6 +1257,7 @@ impl Compiler<'_, '_> { /// Convert the provided `ast::Attr` into a statically known /// string if possible. + // TODO(tazjin): these should probably be SmolStr fn expr_static_attr_str(&self, node: &ast::Attr) -> Option<String> { match node { ast::Attr::Ident(ident) => Some(ident.ident_token().unwrap().text().into()), |