about summary refs log tree commit diff
path: root/tvix/eval/src/compiler/attrs.rs
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-09-17T23·52+0300
committertazjin <tazjin@tvl.su>2022-09-18T21·12+0000
commit0e5baae7ad16ca2a5a70ba34d922cabcaa68d45e (patch)
tree02efc5d294da14df71e8bebc93de97a5d1d2835b /tvix/eval/src/compiler/attrs.rs
parent5dd5c7e254f01f96a2ddfcf2c163c08833ec0061 (diff)
refactor(tvix/eval): clone the Arc<codemap::File> for the compiler r/4907
This disconnects ownership of the `File` reference in a compiler from
the calling scope, which is required for when we implement `import`.

`import` will need to carry an `Rc<RefCell<CodeMap>>` (or maybe, in
the future, Arc) to give us the ability to add new detected code
files at runtime.

Note that the choice of `Arc` over `Rc` here is not ours - it's the
codemap crate's.

Change-Id: I3aeca4ffc167acbd1701846a332d93550b56ba7d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6630
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
Diffstat (limited to 'tvix/eval/src/compiler/attrs.rs')
-rw-r--r--tvix/eval/src/compiler/attrs.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/tvix/eval/src/compiler/attrs.rs b/tvix/eval/src/compiler/attrs.rs
index f1441cff68d2..1584d5017aa2 100644
--- a/tvix/eval/src/compiler/attrs.rs
+++ b/tvix/eval/src/compiler/attrs.rs
@@ -3,7 +3,7 @@
 
 use super::*;
 
-impl Compiler<'_, '_> {
+impl Compiler<'_> {
     pub(super) fn compile_attr(&mut self, slot: LocalIdx, node: ast::Attr) {
         match node {
             ast::Attr::Dynamic(dynamic) => {