feat(tvix/eval): emit warnings on useless inherit r/4529

Change-Id: Ifb9993cf8b85393eb43e1b204c7ab2f889b7113b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6194
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>

1 files changed, 8 insertions, 1 deletions

diff --git a/tvix/eval/src/compiler.rs b/tvix/eval/src/compiler.rs
index e2d194e8ddbb..75ea99ea787c 100644
--- a/tvix/eval/src/compiler.rs
+++ b/tvix/eval/src/compiler.rs
@@ -680,7 +680,14 @@ impl Compiler {
             match inherit.from() {
                 // Within a `let` binding, inheriting from the outer
                 // scope is practically a no-op.
-                None => continue,
+                None => {
+                    self.warnings.push(EvalWarning {
+                        node: inherit.node().clone(),
+                        kind: WarningKind::UselessInherit,
+                    });
+
+                    continue;
+                }
                 Some(_) => todo!("let inherit from attrs"),
             }
         }