refactor(tvix/eval): insert storeDir "builtin" in eval startup r/5887

Instead of using a suspended native thunk, calculate and optionally
insert the storeDir builtin when the VM is constructed.

We already have the IO handle available at this point and can just
check whether a storeDir is present, and insert its absolute value as
a builtin.

Change-Id: If966eee6ff26dc888b6e888e7c46170c0c346b05
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8145
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI

1 files changed, 0 insertions, 10 deletions

diff --git a/tvix/eval/src/builtins/impure.rs b/tvix/eval/src/builtins/impure.rs
index afc85d4c1b40..80736708118c 100644
--- a/tvix/eval/src/builtins/impure.rs
+++ b/tvix/eval/src/builtins/impure.rs
@@ -66,16 +66,6 @@ mod impure_builtins {
 pub fn impure_builtins() -> Vec<(&'static str, Value)> {
     let mut result = impure_builtins::builtins();
 
-    result.push((
-        "storeDir",
-        Value::Thunk(Thunk::new_suspended_native(Box::new(
-            |vm: &mut VM| match vm.io().store_dir() {
-                None => Ok(Value::Null),
-                Some(dir) => Ok(Value::String(dir.into())),
-            },
-        ))),
-    ));
-
     // currentTime pins the time at which evaluation was started
     {
         let seconds = match SystemTime::now().duration_since(UNIX_EPOCH) {