diff options
| author | Aspen Smith <root@gws.fyi> | 2024-07-28T16·11-0400 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-08-07T12·38+0000 |
| commit | b8f92a6d535af09c24ac887855eb230ca25af1ed (patch) | |
| tree | 82cea6a4d3979e0c48e9f97285b8564a24e9ceb0 /tvix/eval/clippy.toml | |
| parent | 1d7ba89c19b231898a997f1af3c13ed8c7247793 (diff) | |
feat(tvix/eval): Forbid Hash{Map,Set}, use Fx instead r/8453
Per https://nnethercote.github.io/perf-book/hashing.html, we have
basically no reason to use the default hasher over a faster,
non-DoS-resistant hasher. This gives a nice perf boost basically for
free:
hello outpath time: [704.76 ms 714.91 ms 725.63 ms]
change: [-7.2391% -6.1018% -4.9189%] (p = 0.00 < 0.05)
Performance has improved.
Change-Id: If5587f444ed3af69f8af4eead6af3ea303b4ae68
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12046
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Autosubmit: aspen <root@gws.fyi>
Diffstat (limited to 'tvix/eval/clippy.toml')
| -rw-r--r-- | tvix/eval/clippy.toml | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tvix/eval/clippy.toml b/tvix/eval/clippy.toml new file mode 100644 index 000000000000..c5302112b3ae --- /dev/null +++ b/tvix/eval/clippy.toml @@ -0,0 +1,3 @@ +# See https://nnethercote.github.io/perf-book/hashing.html. Use FxHashMap and +# FxHashSet, not HashMap and HashSet +disallowed-types = ["std::collections::HashMap", "std::collections::HashSet"] |