diff options
author | Vincent Ambo <mail@tazj.in> | 2022-08-24T13·58+0300 |
---|---|---|
committer | tazjin <tazjin@tvl.su> | 2022-09-02T12·59+0000 |
commit | 3d0280ec03f927ae4925aae400600a7b96058587 (patch) | |
tree | 93dc6dc23bb5fce5655f27cb563a984d3b11eda2 /tvix/eval/.skip-subtree | |
parent | 07fcaf034b17df80de2f37de008562209a76987c (diff) |
refactor(tvix/eval): implement clearer mechanism for globals r/4592
The set of things that can leak out of `builtins` into the global scope is statically known (it is what Nix 2.3 leaks there, essentially). This is a mild change over the previous mechanism, where instead at the point where the `builtins` set is constructed we "lift" the globals out of there (if they exist). This way users will still eventually be able to add additional builtins, HOWEVER they will not be able to leak them into the global scope. Note that upstream Nix technically leaks _all_ builtins into the global scope using the `__*` prefix, but we are trying to avoid this in Tvix if it is not required in nixpkgs. Change-Id: Ie9dec2ce33740134f3b2464eba3749f421dd5953 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6258 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/.skip-subtree')
0 files changed, 0 insertions, 0 deletions