diff options
| author | Simon Hauser <simon.hauser@helsinki-systems.de> | 2024-06-27T08·27+0200 |
|---|---|---|
| committer | Simon Hauser <simon.hauser@helsinki-systems.de> | 2024-07-02T13·43+0000 |
| commit | 618aacaa61972c3e25b8c996abfa1d4dc475154e (patch) | |
| tree | 7fc41bff9ed6e21b36d6768ffd457590f89dba6e /tvix/docs | |
| parent | 7f8da5e6a9926170be2fefc1db847166e5631f16 (diff) | |
feat(tvix/tracing): http trace propagation r/8339
Introduces a helper function within tvix-tracing that returns a reqwest tracing middleware that will ingest the traceparent if otlp is enabled. It is feature flagged in tvix-tracing so not every consumer of that library automatically has reqwest in its dependencies. Tested using netcat to verify that the `traceparent` header is there if otlp is enabled and missing if otlp feature is disabled. Change-Id: I5abccae777b725f5ff7382e3686165383c477a39 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11886 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/docs')
| -rw-r--r-- | tvix/docs/src/TODO.md | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index 127fb6f4d0c1..52fa0a9e7480 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -224,7 +224,6 @@ logs etc, but this is something requiring a lot of designing. - Maybe drop `--log-level` entirely, and only use `RUST_LOG` env exclusively? `debug`,`trace` level across all crates is a bit useless, and `RUST_LOG` can be much more granular… - - Trace propagation for HTTP clients too, using - https://www.w3.org/TR/trace-context/ or https://www.w3.org/TR/baggage/, - whichever makes more sense. - Candidates: nix+http(s) protocol, object_store crates. + - Trace propagation for object_store once they support a way to register a + middleware, so we can use that to register a tracing middleware. + https://github.com/apache/arrow-rs/issues/5990 |