about summary refs log tree commit diff
path: root/tvix/docs
diff options
context:
space:
mode:
authorSimon Hauser <simon.hauser@helsinki-systems.de>2024-06-06T13·44+0200
committerclbot <clbot@tvl.fyi>2024-06-10T16·35+0000
commit825d498908e2f6c9fdca3225afefb0aa4b3cc747 (patch)
tree765e5412bf24ae41bb3d6f42791a229b68a88451 /tvix/docs
parent11a6ff77067a7b9eec3f1c15412d7143cb85a047 (diff)
feat(tvix/tracing): introduce common tvix-tracing crate r/8242
Introduce a new common crate that contains tracing boilerplate which then
can be used in the cli, tvix-store and tvix-build crates.
It has otlp as an optional feature, which is currently only used by
tvix-store.

Change-Id: I41468ac4d9c65174515d721513b96fea463d6ed2
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11758
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: Simon Hauser <simon.hauser@helsinki-systems.de>
Diffstat (limited to 'tvix/docs')
-rw-r--r--tvix/docs/src/TODO.md11
1 files changed, 3 insertions, 8 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md
index 66d90aaa9494..97f5d8b7d67d 100644
--- a/tvix/docs/src/TODO.md
+++ b/tvix/docs/src/TODO.md
@@ -198,14 +198,9 @@ logs etc, but this is something requiring a lot of designing.
 - Some work ongoing on the worker operation parsing (griff, picnoir)
 
 ### O11Y
- - `[tracing-]indicatif` for progress/log reporting (cl/11747)
- - Currently there's a lot of boilerplate in the `tvix-store` CLI entrypoint,
-   and half of the boilerplate copied over to `tvix-cli`.
-   Setup of the tracing things should be unified into the `tvix-tracing` crate,
-   maybe including some of the CLI parameters (@simon).
-   Or maybe drop `--log-level` entirely, and only use `RUST_LOG` env
-   exclusively? `debug`,`trace` level across all crates is a bit useless, and
-   `RUST_LOG` can be much more granular…
+ - Maybe drop `--log-level` entirely, and only use `RUST_LOG` env exclusively?
+   `debug`,`trace` level across all crates is a bit useless, and `RUST_LOG` can
+   be much more granular…
  - The OTLP stack is quite spammy if there's no OTLP collector running on
    localhost.
    https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/