about summary refs log tree commit diff
path: root/tvix/castore/src/directoryservice/mod.rs
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-11-13T11·48+0200
committerflokli <flokli@flokli.de>2023-11-15T06·43+0000
commitc83841d3a13a5d5b3fdaa7f9beecd743f1283691 (patch)
treea7a650962fe78efa9c2c8498301f445dcfe08714 /tvix/castore/src/directoryservice/mod.rs
parent840bee1e979518412774ea452c307bfbef0a561e (diff)
refactor(tvix/castore): remove DirectoryService::from_url r/7021
Make directoryservice::from_addr use the more specific constructors.

Change-Id: I9fee2afed77692505988d631d9fe246d9843d25a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10029
Tested-by: BuildkiteCI
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Diffstat (limited to 'tvix/castore/src/directoryservice/mod.rs')
-rw-r--r--tvix/castore/src/directoryservice/mod.rs6
1 files changed, 0 insertions, 6 deletions
diff --git a/tvix/castore/src/directoryservice/mod.rs b/tvix/castore/src/directoryservice/mod.rs
index 65beeef4a2..41d44078ca 100644
--- a/tvix/castore/src/directoryservice/mod.rs
+++ b/tvix/castore/src/directoryservice/mod.rs
@@ -21,12 +21,6 @@ pub use self::traverse::descend_to;
 /// digest.
 #[async_trait]
 pub trait DirectoryService: Send + Sync {
-    /// Create a new instance by passing in a connection URL.
-    /// TODO: check if we want to make this async, instead of lazily connecting
-    fn from_url(url: &url::Url) -> Result<Self, Error>
-    where
-        Self: Sized;
-
     /// Get looks up a single Directory message by its digest.
     /// In case the directory is not found, Ok(None) is returned.
     async fn get(&self, digest: &B3Digest) -> Result<Option<proto::Directory>, Error>;