about summary refs log tree commit diff
path: root/tvix/castore/src/blobservice/mod.rs
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-11-13T11·41+0200
committerflokli <flokli@flokli.de>2023-11-15T06·43+0000
commit840bee1e979518412774ea452c307bfbef0a561e (patch)
treed96219ca4ded32b288fd4f8fd4671f0eb9ddb9ca /tvix/castore/src/blobservice/mod.rs
parent25eca8af32de7028ceb7ef23809948d287322c21 (diff)
refactor(tvix/castore/blobsvc): remove BlobService::from_url r/7020
Make blobservice::from_addr use the more specific constructors.

Change-Id: Id9637e279d6910ce6d92ff0086a984be5c65a8c8
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10028
Tested-by: BuildkiteCI
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Diffstat (limited to 'tvix/castore/src/blobservice/mod.rs')
-rw-r--r--tvix/castore/src/blobservice/mod.rs6
1 files changed, 0 insertions, 6 deletions
diff --git a/tvix/castore/src/blobservice/mod.rs b/tvix/castore/src/blobservice/mod.rs
index 5ecf25ac1337..3267116e404e 100644
--- a/tvix/castore/src/blobservice/mod.rs
+++ b/tvix/castore/src/blobservice/mod.rs
@@ -24,12 +24,6 @@ pub use self::sled::SledBlobService;
 /// close funtion, to finalize a blob and get its digest.
 #[async_trait]
 pub trait BlobService: Send + Sync {
-    /// Create a new instance by passing in a connection URL.
-    /// TODO: check if we want to make this async, instead of lazily connecting
-    fn from_url(url: &url::Url) -> Result<Self, Error>
-    where
-        Self: Sized;
-
     /// Check if the service has the blob, by its content hash.
     async fn has(&self, digest: &B3Digest) -> Result<bool, Error>;