about summary refs log tree commit diff
path: root/tvix/castore/protos
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-06-29T17·09+0300
committerflokli <flokli@flokli.de>2024-06-29T19·23+0000
commitbba64d876215e19fe588c72f168dc4b033581f6e (patch)
tree2891c216b3b64dd3b7c3b835964bd368cbcc7335 /tvix/castore/protos
parentd0ef6a50df6760702bf970c0cee71a5cdbff21b8 (diff)
fix(tvix/castore/object_store): make query pairs object_store opts r/8329
We previously called ObjectStoreBlobService::parse_url, which passes an
empty list of options when constructing the ObjectStore.

This is most likely not what we want. The more reasonable thing to do is
pass along the query string (pairs) as options to
`object_store::parse_url_opts`, and remove them from the plain URL we
pass to object_store itself.

Change-Id: Ic2cb1dca2a2980a863165d81baa3323a355cf3fe
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11897
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/castore/protos')
0 files changed, 0 insertions, 0 deletions