diff options
author | Florian Klink <flokli@flokli.de> | 2024-04-22T11·02+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-04-23T12·30+0000 |
commit | 091de12a9a735e71c119e543dab9f2999a36a5a1 (patch) | |
tree | 8df65d32934e026cec80256226da031954f715c1 /tvix/castore-go | |
parent | dc444e55dcb75a634bce94fef9e29d90ea90fe5f (diff) |
refactor(tvix/glue): move Fetch[er] into its own types, fetch lazily r/7993
We actually want to delay fetching until we actually need the file. A simple evaluation asking for `.outPath` or `.drvPath` should work even in a pure offline environment. Before this CL, the fetching logic was quite distributed between tvix_store_io, and builtins/fetchers.rs. Rather than having various functions and conversions between structs, describe a Fetch as an enum type, with the fields describing the fetch. Define a store_path() function on top of `Fetch` which can be used to ask for the calculated store path (if the digest has been provided upfront). Have a `Fetcher` struct, and give it a `fetch_and_persist` function, taking a `Fetch` as well as a desired name, and have it deal with all the logic of persisting the PathInfos. It also returns a StorePathRef, similar to the `.store_path()` method on a `Fetch` struct. In a followup CL, we can extend KnownPaths to track fetches AND derivations, and then use `Fetcher` when we need to do IO into that store path. Change-Id: Ib39a96baeb661750a8706b461f8ba4abb342e777 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11500 Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/castore-go')
0 files changed, 0 insertions, 0 deletions