diff options
author | sterni <sternenseemann@systemli.org> | 2023-12-25T14·53+0100 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-12-25T15·06+0000 |
commit | d07600dbca4d3b0898c203857f74a4e9f5b6b4c3 (patch) | |
tree | 4d828160196dd14728f0f0f622297fb8e536a15d /tvix/castore-go/rpc_directory_grpc.pb.go | |
parent | 32e8e16e1e8bc44851d49f3c4c684753d7d2ee24 (diff) |
fix(tvix/eval/value): correctly emit spaces when coercing lists r/7264
r/7176 introduced an incorrect assumption was the benefit of the nonrecursive coercion algorithm, namely that a coercion operation always returns a non empty string. This allows to detect whether we are coercing a list or not by checking if the intermediate result is empty or not. Unfortunately, coercing null and false yields an empty string, so we need to explicitly track whether we are coercing a list. Updated the test case to hopefully catch similar bugs in the future. I'm not a hundred percent certain I have not introduced a new edge case with this, so it may be interesting to add a prop test case for this to nix_oracle down the line. At least lists are the only nested data structures that can be serialized as nested data structures, so the problem is kind of limited. Change-Id: Ia41e904356f1c41a9d35e4e65ec02f2fe5a4100e Reviewed-on: https://cl.tvl.fyi/c/depot/+/10418 Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/castore-go/rpc_directory_grpc.pb.go')
0 files changed, 0 insertions, 0 deletions