diff options
author | Ilan Joselevich <personal@ilanjoselevich.com> | 2024-05-26T14·27+0300 |
---|---|---|
committer | Ilan Joselevich <personal@ilanjoselevich.com> | 2024-06-03T16·35+0000 |
commit | 1b39d5868adb93175202353b910789f323e63ce1 (patch) | |
tree | 2469a20f90b93e299a0ea05c1fc0132684c9e374 /tvix/README.md | |
parent | c93849a3fc943d106532e94ccf06cbe19e49d929 (diff) |
feat(tvix): add CI targets for checking crate features powerset r/8211
Closes: https://b.tvl.fyi/issues/401 With this change all crate features (and their combinations) will be built and tested in CI. From now on, when adding/removing a Cargo feature for a crate, you will want to add it to the features power set that gets tested in CI. For each crate there's a default.nix with a `mkFeaturePowerset` invocation, modify the list to include/remove the feature. Note that you don't want to add "collection" features, such as `fs` for tvix-[ca]store or `default`. Change-Id: I966dde1413d057770787da3296cce9c1924570e0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11717 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/README.md')
-rw-r--r-- | tvix/README.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tvix/README.md b/tvix/README.md index fb536bc229c0..7f3fcc061597 100644 --- a/tvix/README.md +++ b/tvix/README.md @@ -104,6 +104,11 @@ Rust projects under `//tvix`, be sure to run `mg run //tools:crate2nix-generate` in `//tvix` itself and commit the changes to the generated `Cargo.nix` file. This only applies to the full TVL checkout. +When adding/removing a Cargo feature for a crate, you will want to add it to the +features power set that gets tested in CI. For each crate there's a default.nix with a +`mkFeaturePowerset` invocation, modify the list to include/remove the feature. +Note that you don't want to add "collection" features, such as `fs` for tvix-[ca]store or `default`. + ## License structure All code implemented for Tvix is licensed under the GPL-3.0, with the |