diff options
author | Aspen Smith <root@gws.fyi> | 2024-07-28T16·50-0400 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-08-10T15·28+0000 |
commit | d378111d774777f4a5f319946d26e3d481a49870 (patch) | |
tree | 50f3f40d24e00ab3f5d9e5a7ea0dc3b543ba34d3 /tvix/Cargo.nix | |
parent | a6d6fc418de0cdce921698410265fa78ca6b7f23 (diff) |
feat(tvix/eval): Store hash in key of interner r/8474
Rather than storing the leaked allocation for the string as the key in the interner, store the hash (using NoHashHashBuilder). I thought this would improve performance, but it doesn't: hello outpath time: [736.85 ms 748.42 ms 760.42 ms] change: [-2.0754% +0.4798% +2.7096%] (p = 0.72 > 0.05) No change in performance detected. but it at least doesn't *hurt* performance, and it *does* avoid an `unsafe`, so it's probably net good. Change-Id: Ie413955bdb6f04b1f468f511e5ebce56e329fa37 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12049 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: aspen <root@gws.fyi>
Diffstat (limited to 'tvix/Cargo.nix')
-rw-r--r-- | tvix/Cargo.nix | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/tvix/Cargo.nix b/tvix/Cargo.nix index 9df3c8af8ef5..33805ced0726 100644 --- a/tvix/Cargo.nix +++ b/tvix/Cargo.nix @@ -7525,6 +7525,19 @@ rec { }; resolvedDefaultFeatures = [ "async" "default" "pin-project-lite" "tokio" "wire" ]; }; + "nohash-hasher" = rec { + crateName = "nohash-hasher"; + version = "0.2.0"; + edition = "2018"; + sha256 = "0lf4p6k01w4wm7zn4grnihzj8s7zd5qczjmzng7wviwxawih5x9b"; + authors = [ + "Parity Technologies <admin@parity.io>" + ]; + features = { + "default" = [ "std" ]; + }; + resolvedDefaultFeatures = [ "default" "std" ]; + }; "nom" = rec { crateName = "nom"; version = "7.1.3"; @@ -16043,6 +16056,10 @@ rec { packageId = "md-5"; } { + name = "nohash-hasher"; + packageId = "nohash-hasher"; + } + { name = "os_str_bytes"; packageId = "os_str_bytes"; features = [ "conversions" ]; |