diff options
| author | Aspen Smith <root@gws.fyi> | 2024-07-28T16·50-0400 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-08-10T15·28+0000 |
| commit | d378111d774777f4a5f319946d26e3d481a49870 (patch) | |
| tree | 50f3f40d24e00ab3f5d9e5a7ea0dc3b543ba34d3 /tvix/Cargo.lock | |
| parent | a6d6fc418de0cdce921698410265fa78ca6b7f23 (diff) | |
feat(tvix/eval): Store hash in key of interner r/8474
Rather than storing the leaked allocation for the string as the key in
the interner, store the hash (using NoHashHashBuilder). I thought this
would improve performance, but it doesn't:
hello outpath time: [736.85 ms 748.42 ms 760.42 ms]
change: [-2.0754% +0.4798% +2.7096%] (p = 0.72 > 0.05)
No change in performance detected.
but it at least doesn't *hurt* performance, and it *does* avoid an
`unsafe`, so it's probably net good.
Change-Id: Ie413955bdb6f04b1f468f511e5ebce56e329fa37
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12049
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: aspen <root@gws.fyi>
Diffstat (limited to 'tvix/Cargo.lock')
| -rw-r--r-- | tvix/Cargo.lock | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tvix/Cargo.lock b/tvix/Cargo.lock index 9bea027e4de3..e92803e99032 100644 --- a/tvix/Cargo.lock +++ b/tvix/Cargo.lock @@ -2401,6 +2401,12 @@ dependencies = [ ] [[package]] +name = "nohash-hasher" +version = "0.2.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "2bf50223579dc7cdcfb3bfcacf7069ff68243f8c363f62ffa99cf000a6b9c451" + +[[package]] name = "nom" version = "7.1.3" source = "registry+https://github.com/rust-lang/crates.io-index" @@ -4907,6 +4913,7 @@ dependencies = [ "lexical-core", "md-5", "mimalloc", + "nohash-hasher", "os_str_bytes", "path-clean", "pretty_assertions", |