diff options
| author | Aspen Smith <root@gws.fyi> | 2024-07-28T16·11-0400 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-08-07T12·38+0000 |
| commit | b8f92a6d535af09c24ac887855eb230ca25af1ed (patch) | |
| tree | 82cea6a4d3979e0c48e9f97285b8564a24e9ceb0 /tvix/Cargo.lock | |
| parent | 1d7ba89c19b231898a997f1af3c13ed8c7247793 (diff) | |
feat(tvix/eval): Forbid Hash{Map,Set}, use Fx instead r/8453
Per https://nnethercote.github.io/perf-book/hashing.html, we have
basically no reason to use the default hasher over a faster,
non-DoS-resistant hasher. This gives a nice perf boost basically for
free:
hello outpath time: [704.76 ms 714.91 ms 725.63 ms]
change: [-7.2391% -6.1018% -4.9189%] (p = 0.00 < 0.05)
Performance has improved.
Change-Id: If5587f444ed3af69f8af4eead6af3ea303b4ae68
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12046
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Autosubmit: aspen <root@gws.fyi>
Diffstat (limited to 'tvix/Cargo.lock')
| -rw-r--r-- | tvix/Cargo.lock | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/tvix/Cargo.lock b/tvix/Cargo.lock index cb3ed4c096e8..8e5c67bc4307 100644 --- a/tvix/Cargo.lock +++ b/tvix/Cargo.lock @@ -3085,7 +3085,7 @@ dependencies = [ "pin-project-lite", "quinn-proto", "quinn-udp", - "rustc-hash", + "rustc-hash 1.1.0", "rustls 0.23.7", "thiserror", "tokio", @@ -3101,7 +3101,7 @@ dependencies = [ "bytes", "rand", "ring", - "rustc-hash", + "rustc-hash 1.1.0", "rustls 0.23.7", "slab", "thiserror", @@ -3416,7 +3416,7 @@ dependencies = [ "countme", "hashbrown 0.14.3", "memoffset 0.9.0", - "rustc-hash", + "rustc-hash 1.1.0", "text-size", ] @@ -3474,6 +3474,12 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "08d43f7aa6b08d49f382cde6a7982047c3426db949b1424bc4b7ec9ae12c6ce2" [[package]] +name = "rustc-hash" +version = "2.0.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "583034fd73374156e66797ed8e5b0d5690409c9226b22d87cb7f19821c05d152" + +[[package]] name = "rustc_version" version = "0.4.0" source = "registry+https://github.com/rust-lang/crates.io-index" @@ -4864,6 +4870,7 @@ dependencies = [ "nix-compat", "rnix", "rowan", + "rustc-hash 2.0.0", "rustyline", "smol_str", "thiserror", @@ -4905,6 +4912,7 @@ dependencies = [ "rnix", "rowan", "rstest", + "rustc-hash 2.0.0", "serde", "serde_json", "sha1", |