about summary refs log tree commit diff
path: root/tools
diff options
context:
space:
mode:
authorYureka <tvl@yuka.dev>2024-06-15T16·24+0200
committerclbot <clbot@tvl.fyi>2024-06-16T05·01+0000
commitdaada1b2fa7732f1b144a3bb43a096f7b485a0da (patch)
tree1cf08dc411e9a23ffb4085f25458db100c339f57 /tools
parentc2a9ad35830056dcaf6a0e1726dcc4dc094cf962 (diff)
refactor(castore/directory): separate order logic from ClosureValidator r/8282
ClosureValidator was previously only suitable for a very narrow use case:
Validating incoming uploads, which are in leaves-to-root order.
This is because the ordering validation was hard-wired into the add()
function.
This
- Re-name ClosureValidator to DirectoryGraph, which is more suitable
  since it actually stores the Directory structs and is drained in the end.
- Move the ordering-related logic to a separate OrderValidator, which
  can be used independently.
- re-write DirectoryGraph to be a general purpose
  validator which can accept the input in both orders
  and can be drained in both orders as well.

This means the DirectoryGraph and OrderValidator can now serve
multiple new purposes:
- Validating the incoming closure on the client while downloading.
- Validating the incoming closure downloaded in a caching layer from the
  `far` cache, and re-order it for insertion into the `near` cache.

Change-Id: I2b4b226348416912d7a31935bec050e53d911b70
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11708
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: yuka <yuka@yuka.dev>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions