about summary refs log tree commit diff
path: root/tools/nixery
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-09-09T07·06+0300
committertazjin <tazjin@tvl.su>2022-09-11T12·26+0000
commita0acbfa47070b3fac9fb2c72ece57edb2c9faa10 (patch)
tree365f779b5de9533e36c7de406d65a198b19c66a1 /tools/nixery
parent39509683a28b6a3283872d3327dd657a9527b8de (diff)
refactor(tvix/eval): refactor methods for parsing static idents r/4811
Refactors the methods used for determining whether an identifier in a
binding (i.e. an `rnix::Attr` node) is a static string, and extracting
it.

Previously all uses of this logic were for `let`-expressions, where
dynamic attributes are always an error. However, we need the same
logic to properly implement the phase separation of attribute set
compilation.

To facilitate this, the actual core logic of these methods now return
`Option`, and are only converted to errors in cases where the errors
are actually required.

Change-Id: Iad7826eff2cb428182521c6f92276310edeae1eb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6498
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tools/nixery')
0 files changed, 0 insertions, 0 deletions