about summary refs log tree commit diff
path: root/tools/nixery/storage/gcs.go
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2021-04-29T14·02+0200
committerVincent Ambo <mail@tazj.in>2021-04-29T21·55+0200
commit7e8295189bbcd4a30ea684c65c0a3c343d4842a9 (patch)
tree661de1dfb2ee264b08882f569c4c79a5d7462ae7 /tools/nixery/storage/gcs.go
parent970f49223599ec124809ead7be0b61e3e30431f9 (diff)
docs: document unset GOOGLE_APPLICATION_CREDENTIALS
In case the `GOOGLE_APPLICATION_CREDENTIALS` environment variable is not
set, a redirect to storage.googleapis.com is issued, which means the
underlying bucket objects need to be publicly accessible.

This wasn't really obvious until now, so further clarify it.
Diffstat (limited to 'tools/nixery/storage/gcs.go')
-rw-r--r--tools/nixery/storage/gcs.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/nixery/storage/gcs.go b/tools/nixery/storage/gcs.go
index eac34461af76..a4bb4ba31f67 100644
--- a/tools/nixery/storage/gcs.go
+++ b/tools/nixery/storage/gcs.go
@@ -222,6 +222,10 @@ func signingOptsFromEnv() (*storage.SignedURLOptions, error) {
 // Signing the URL allows unauthenticated clients to retrieve objects from the
 // bucket.
 //
+// In case signing is not configured, a redirect to storage.googleapis.com is
+// issued, which means the underlying bucket objects need to be publicly
+// accessible.
+//
 // The Docker client is known to follow redirects, but this might not be true
 // for all other registry clients.
 func (b *GCSBackend) constructLayerUrl(digest string) (string, error) {