about summary refs log tree commit diff
path: root/tools/nixery/server/layers/grouping.go
diff options
context:
space:
mode:
authorVincent Ambo <tazjin@google.com>2019-10-28T21·39+0100
committerVincent Ambo <github@tazj.in>2019-10-29T18·16+0100
commit2d4a3ea307350e1f7495a4fb6c6f5a37d10d3912 (patch)
treebe189aee1dd7d1755a15ca182db547edd2f4d869 /tools/nixery/server/layers/grouping.go
parent904c3dade00881c6872dc633a135e12bdfe7e76b (diff)
chore(server): Remove outdated TODO
Real-life experience has shown that the weighting of the metric
produced here is appropriate.
Diffstat (limited to 'tools/nixery/server/layers/grouping.go')
-rw-r--r--tools/nixery/server/layers/grouping.go6
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/nixery/server/layers/grouping.go b/tools/nixery/server/layers/grouping.go
index 1fbbf33db3d7..74952a137835 100644
--- a/tools/nixery/server/layers/grouping.go
+++ b/tools/nixery/server/layers/grouping.go
@@ -300,11 +300,7 @@ func groupLayer(dt *flow.DominatorTree, root *closure) Layer {
 	sort.Strings(contents)
 
 	return Layer{
-		Contents: contents,
-		// TODO(tazjin): The point of this is to factor in
-		// both the size and the popularity when making merge
-		// decisions, but there might be a smarter way to do
-		// it than a plain multiplication.
+		Contents:    contents,
 		MergeRating: uint64(root.Popularity) * size,
 	}
 }