diff options
author | Jérôme Petazzoni <jerome.petazzoni@gmail.com> | 2021-04-22T14·52+0200 |
---|---|---|
committer | Vincent Ambo <mail@tazj.in> | 2021-06-25T23·27+0200 |
commit | 94e04a76b6d2baf0cc5060c3168a428fae6c28ab (patch) | |
tree | 04a5038cb960b7f49aa7a18baf4f094423ce057c /tools/nixery/go.mod | |
parent | 3efbbfcd4e22811dd549c6ed46374736308b0b82 (diff) |
feat(storage): Store blob content-type in extended attributes
After the discussion in #116, this stores the blob content types in extended attributes when using the filesystem backend. If the underlying filesystem doesn't support extended attributes, storing blobs won't work; also, if extended attributes get removed, blobs won't be served anymore. We can relax this behavior if needed (i.e. log errors but still accept to store or serve blobs). However, since the Docker Engine (and possibly other container engines) won't accept to pull images from a registry that doesn't use correct content types for manifest files, it could be argued that it's better to give a hard fail. (Otherwise, the container engine gives cryptic error messages like "missing signature key".) I can change that behavior (and log errors but still store/serve blobs to the filesystem) if you think it's better.
Diffstat (limited to 'tools/nixery/go.mod')
-rw-r--r-- | tools/nixery/go.mod | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/nixery/go.mod b/tools/nixery/go.mod index e24b2b6ff579..3b819a7965c0 100644 --- a/tools/nixery/go.mod +++ b/tools/nixery/go.mod @@ -5,6 +5,7 @@ go 1.15 require ( cloud.google.com/go/storage v1.15.0 github.com/google/go-cmp v0.5.5 + github.com/pkg/xattr v0.4.3 github.com/sirupsen/logrus v1.8.1 golang.org/x/oauth2 v0.0.0-20210427180440-81ed05c6b58c gonum.org/v1/gonum v0.9.1 |