about summary refs log tree commit diff
path: root/tools/gerrit-cli.nix
diff options
context:
space:
mode:
authorGriffin Smith <grfn@gws.fyi>2020-08-27T15·28-0400
committerglittershark <grfn@gws.fyi>2020-08-28T01·18+0000
commit3bada1d41eed3bd8c72d6811147cd100fcb585ca (patch)
treea9374045cf235c25f910ed3df696cf484f0a8fdc /tools/gerrit-cli.nix
parent4ff9d5dee86999b559da4b515ec12533787dc564 (diff)
refactor(tvix): Clean up MixEvalArgs internals r/1726
Previously, MixEvalArgs (a generic data type used to handle --arg,
--argstr, and -I arguments to `nix-build`, `nix eval`, etc.) was storing
the difference between --arg and --argstr by prepending a single
character (either 'E' or 'S') to the value of the arg. This is messy and
un-type-safe, so this commit refactors that to use a proper enum and a
std::pair, which allows us to add a switch and get totality checking.
yay, types!

Change-Id: I883f8db3136d05dda190fac0a1b494386c2ff87b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1862
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Diffstat (limited to 'tools/gerrit-cli.nix')
0 files changed, 0 insertions, 0 deletions