about summary refs log tree commit diff
path: root/tools/crfo-approve.nix
diff options
context:
space:
mode:
authorAdam Joseph <adam@westernsemico.com>2023-12-09T07·16-0800
committerclbot <clbot@tvl.fyi>2023-12-12T14·26+0000
commitae28dc3ca64eb09d0ed792f0145576c17920ede5 (patch)
tree56e68f7c3c27cae28bb7fd30524b254c6b5b11fe /tools/crfo-approve.nix
parentedbd5055a1c3ca429b4c58d23f140a9fb76c3fc8 (diff)
test(tvix/eval): test for b/338 catchable hygiene problem r/7168
Commit 05f42519b53575ad3235b5e0a0cd7d71f04076a5 fixed b/281 by
establishing a hygiene regimen to partition *catchable* errors
(i.e. those which tryEval can detect) from all other errors, like
internal VM failures or I/O errors (which Nix must not be allowed to
detect, since these errors are fundamentally impure).

Unfotunately there are still cases where tvix assumes that anything
other than Value::Bool means it should panic!().  I found another
one, and added a test case for it in:

  eval_okay_src_tests_tvix_tests_eval_okay_compare_ordering_catchable_nix

Not yet passing.

Change-Id: I69c62ed9ea5c8f81870e8de5c5fe12dcde849763
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10220
Autosubmit: Adam Joseph <adam@westernsemico.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Diffstat (limited to 'tools/crfo-approve.nix')
0 files changed, 0 insertions, 0 deletions