about summary refs log tree commit diff
path: root/third_party
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2022-02-04T11·15+0100
committerclbot <clbot@tvl.fyi>2022-02-04T15·55+0000
commita2ecd53f5822ae07fabfc7d2fac7fa929eb7f795 (patch)
treeffcce1a3540e65bbc04adc0344c7a1c34501768c /third_party
parent0e45761853cbde42001f85e361f407fe9d1afdd6 (diff)
chore: clean up some obsolete TODOs r/3768
* //3p/nix: probably not worth investing time into this anymore

* //users/sterni/emacs: The emoji problem disappeared by itself with a
  newer emacs version, however a different one remains…

* //web/panettone: If we ever want to change the behavior, we should
  just decide the behavior statically instead of using conditions and
  restarts, as we only call it in one place, so making different
  decisions depending on call sites is not really a use case we have.

Change-Id: Iff9d439ce356db41ce34d690fb7b6a01822022fa
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5223
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'third_party')
-rw-r--r--third_party/nix/src/libexpr/primops.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/third_party/nix/src/libexpr/primops.cc b/third_party/nix/src/libexpr/primops.cc
index 710d214ce7c2..f196c5ed723c 100644
--- a/third_party/nix/src/libexpr/primops.cc
+++ b/third_party/nix/src/libexpr/primops.cc
@@ -1370,7 +1370,6 @@ static void prim_functionArgs(EvalState& state, const Pos& pos, Value** args,
                               Value& v) {
   state.forceValue(*args[0]);
   if (args[0]->type == tPrimOpApp || args[0]->type == tPrimOp) {
-    // TODO(sterni): return set of formal arguments for fetch* primops
     state.mkAttrs(v, 0);
     return;
   }