about summary refs log tree commit diff
path: root/third_party/overlays/tvl.nix
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2022-02-26T11·35+0100
committerclbot <clbot@tvl.fyi>2022-02-26T22·29+0000
commit20bdcdb8f5249d1441254555e9ded5453671ff59 (patch)
treefb7bd066b26067172229960be21d765cbdc66c23 /third_party/overlays/tvl.nix
parent4c00ca0421133eecc0918b70831ce4cd71f10f6b (diff)
chore(3p/sources): Bump channels & overlays r/3871
* //3p/overlays/tvl: propagate git as a native build input from magit,
  because magit checks the version of git at load time ever since a
  recent commit [1]. This check been escalated to a failure in a
  subsequent commit [2]. The result is that anything require-ing magit
  will fail with an error if git is not in PATH (or a path to git
  provided) which is basically what happens in byte compilation of all
  packages that depend on magit.

  For now the easiest way to work around it is letting magit have its
  way and provide git which easy enough for it. Upstream should probably
  think about this behaviour or emacs-overlay address it somehow. For
  now I've opened an issue with magit [3].

[1]: https://github.com/magit/magit/commit/6c4ff54a0836985fac6d72c7e4bfeff964775efe
[2]: https://github.com/magit/magit/commit/8394f0d4ea5ffa6858db314efabe91d99f78e67a
[3]: https://github.com/magit/magit/issues/4614

Change-Id: I6aaf8258c3798b76cdaa6eef066c6224e374e02e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5326
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'third_party/overlays/tvl.nix')
-rw-r--r--third_party/overlays/tvl.nix7
1 files changed, 7 insertions, 0 deletions
diff --git a/third_party/overlays/tvl.nix b/third_party/overlays/tvl.nix
index 7b2bb12fcae5..4cd2bd3ef55c 100644
--- a/third_party/overlays/tvl.nix
+++ b/third_party/overlays/tvl.nix
@@ -31,6 +31,13 @@ self: super: {
       exwm = esuper.exwm.overrideAttrs (_: {
         src = depot.path.origSrc + "/third_party/exwm";
       });
+
+      # Workaround for magit checking the git version at load time
+      magit = esuper.magit.overrideAttrs (_: {
+        propagatedNativeBuildInputs = [
+          self.git
+        ];
+      });
     })
   );