diff options
author | Griffin Smith <grfn@gws.fyi> | 2020-07-23T21·18-0400 |
---|---|---|
committer | glittershark <grfn@gws.fyi> | 2020-07-25T00·04+0000 |
commit | 2fcf2d0d20f7e67a80c2cb5b2d0a437faed6efb7 (patch) | |
tree | 06dcd7864bd12b60d1beaf895f79177300988375 /third_party/nix/src/tests/lang/parse-okay-dup-attrs-6.nix | |
parent | ece66d081b1833ee0bb508fad2843f2d49c9e50d (diff) |
refactor(3p/nix): Remove custom base64 implementation r/1462
Replace the custom, rather questionable base64 implementation with absl::Base64{Une,E}scape. To make sure that the custom implementation was doing the same thing I've also added a test covering nix::Hash::to_string, which was one function that used it - the test passed prior to the replacement, and continued to pass afterwards. The previous base64Decode function threw an exception on failure - to avoid going too far down the rabbit hole I've replicated that functionality at all call sites, but this should be replaced with more sensible error handling such as StatusOr eventually. Also, before this change: ❯ nix eval -f . users.tazjin.emacs.outPath "/nix/store/g6ri2q8nra96ix20bcsc734r1yyaylb1-tazjins-emacs" And after: ❯ ./result/bin/nix eval -f . users.tazjin.emacs.outPath "/nix/store/g6ri2q8nra96ix20bcsc734r1yyaylb1-tazjins-emacs" Change-Id: Id292ffbb82fe808f3f1b34670afbe7b8c13ad615 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1385 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
Diffstat (limited to 'third_party/nix/src/tests/lang/parse-okay-dup-attrs-6.nix')
0 files changed, 0 insertions, 0 deletions