about summary refs log tree commit diff
path: root/third_party/nix/src/nix/ls.cc
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2020-07-19T20·52+0100
committertazjin <mail@tazj.in>2020-07-19T22·00+0000
commit15afa8472e1b1bbf236d4cf8e9f399345c48d3fe (patch)
tree88e475abad625ea4fed00525ab7d2ff882238a59 /third_party/nix/src/nix/ls.cc
parentca50fb66d26a589dbc2935de68d95716b595a07a (diff)
fix(3p/nix): Fix all remaining compiler warnings r/1403
This compiles under `-Wall -Werror`.

The largest chunk of this change is `final` qualifiers for the various
Nix CLI command structs, which inherit from a Command class that has
more virtual functions than are implemented by each command.

Change-Id: I0925e6e1a39013f026773db5816e4a77d50f3b4a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1294
Tested-by: BuildkiteCI
Reviewed-by: isomer <isomer@tvl.fyi>
Reviewed-by: kanepyork <rikingcoding@gmail.com>
Diffstat (limited to 'third_party/nix/src/nix/ls.cc')
-rw-r--r--third_party/nix/src/nix/ls.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/nix/src/nix/ls.cc b/third_party/nix/src/nix/ls.cc
index aa461675ad..afa4db92bc 100644
--- a/third_party/nix/src/nix/ls.cc
+++ b/third_party/nix/src/nix/ls.cc
@@ -88,7 +88,7 @@ struct MixLs : virtual Args, MixJSON {
   }
 };
 
-struct CmdLsStore : StoreCommand, MixLs {
+struct CmdLsStore final : StoreCommand, MixLs {
   CmdLsStore() { expectArg("path", &path); }
 
   Examples examples() override {
@@ -108,7 +108,7 @@ struct CmdLsStore : StoreCommand, MixLs {
   void run(ref<Store> store) override { list(store->getFSAccessor()); }
 };
 
-struct CmdLsNar : Command, MixLs {
+struct CmdLsNar final : Command, MixLs {
   Path narPath;
 
   CmdLsNar() {