refactor(3p/nix): Apply clang-tidy's modernize-* fixes r/787

This applies the modernization fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html

The 'modernize-use-trailing-return-type' fix was excluded due to my
personal preference (more specifically, I think the 'auto' keyword is
misleading in that position).

1 files changed, 7 insertions, 5 deletions

diff --git a/third_party/nix/src/nix/installables.cc b/third_party/nix/src/nix/installables.cc
index 2d896e3bb9..06419f1f12 100644
--- a/third_party/nix/src/nix/installables.cc
+++ b/third_party/nix/src/nix/installables.cc
@@ -1,4 +1,5 @@
 #include <regex>
+#include <utility>
 
 #include "attr-path.hh"
 #include "command.hh"
@@ -100,7 +101,8 @@ Buildable Installable::toBuildable() {
 struct InstallableStorePath : Installable {
   Path storePath;
 
-  explicit InstallableStorePath(const Path& storePath) : storePath(storePath) {}
+  explicit InstallableStorePath(Path storePath)
+      : storePath(std::move(storePath)) {}
 
   std::string what() override { return storePath; }
 
@@ -160,8 +162,8 @@ struct InstallableValue : Installable {
 struct InstallableExpr : InstallableValue {
   std::string text;
 
-  InstallableExpr(SourceExprCommand& cmd, const std::string& text)
-      : InstallableValue(cmd), text(text) {}
+  InstallableExpr(SourceExprCommand& cmd, std::string text)
+      : InstallableValue(cmd), text(std::move(text)) {}
 
   std::string what() override { return text; }
 
@@ -175,8 +177,8 @@ struct InstallableExpr : InstallableValue {
 struct InstallableAttrPath : InstallableValue {
   std::string attrPath;
 
-  InstallableAttrPath(SourceExprCommand& cmd, const std::string& attrPath)
-      : InstallableValue(cmd), attrPath(attrPath) {}
+  InstallableAttrPath(SourceExprCommand& cmd, std::string attrPath)
+      : InstallableValue(cmd), attrPath(std::move(attrPath)) {}
 
   std::string what() override { return attrPath; }