about summary refs log tree commit diff
path: root/third_party/nix/src/nix-prefetch-url
diff options
context:
space:
mode:
authorVincent Ambo <tazjin@google.com>2020-05-20T21·27+0100
committerVincent Ambo <tazjin@google.com>2020-05-20T21·27+0100
commit689ef502f5b0655c9923ed77da2ae3504630f473 (patch)
tree3e331c153646f136875f047cc3b9f0aad8c86341 /third_party/nix/src/nix-prefetch-url
parentd331d3a0b5c497a46e2636f308234be66566c04c (diff)
refactor(3p/nix): Apply clang-tidy's readability-* fixes r/788
This applies the readability fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
Diffstat (limited to 'third_party/nix/src/nix-prefetch-url')
-rw-r--r--third_party/nix/src/nix-prefetch-url/nix-prefetch-url.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/third_party/nix/src/nix-prefetch-url/nix-prefetch-url.cc b/third_party/nix/src/nix-prefetch-url/nix-prefetch-url.cc
index 8c92af19d5f3..5a9b81103d79 100644
--- a/third_party/nix/src/nix-prefetch-url/nix-prefetch-url.cc
+++ b/third_party/nix/src/nix-prefetch-url/nix-prefetch-url.cc
@@ -57,7 +57,7 @@ static int _main(int argc, char** argv) {
   {
     HashType ht = htSHA256;
     std::vector<string> args;
-    bool printPath = getEnv("PRINT_PATH") != "";
+    bool printPath = !getEnv("PRINT_PATH").empty();
     bool fromExpr = false;
     string attrPath;
     bool unpack = false;
@@ -163,7 +163,8 @@ static int _main(int argc, char** argv) {
 
     /* If an expected hash is given, the file may already exist in
        the store. */
-    Hash hash, expectedHash(ht);
+    Hash hash;
+    Hash expectedHash(ht);
     Path storePath;
     if (args.size() == 2) {
       expectedHash = Hash(args[1], ht);