diff options
| author | Vincent Ambo <tazjin@google.com> | 2020-05-20T03·33+0100 |
|---|---|---|
| committer | Vincent Ambo <tazjin@google.com> | 2020-05-20T03·33+0100 |
| commit | d331d3a0b5c497a46e2636f308234be66566c04c (patch) | |
| tree | 92526b2f99456c09c5cc81233ed5a4311abe3d2b /third_party/nix/src/libutil/xml-writer.cc | |
| parent | fed31b2c9b364fc1ed0b724c21b068cdedf46ee7 (diff) | |
refactor(3p/nix): Apply clang-tidy's modernize-* fixes r/787
This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
Diffstat (limited to 'third_party/nix/src/libutil/xml-writer.cc')
| -rw-r--r-- | third_party/nix/src/libutil/xml-writer.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/third_party/nix/src/libutil/xml-writer.cc b/third_party/nix/src/libutil/xml-writer.cc index ed41286cc1a3..11cd632399ad 100644 --- a/third_party/nix/src/libutil/xml-writer.cc +++ b/third_party/nix/src/libutil/xml-writer.cc @@ -1,6 +1,6 @@ #include "xml-writer.hh" -#include <assert.h> +#include <cassert> namespace nix { @@ -68,8 +68,7 @@ void XMLWriter::writeEmptyElement(const string& name, const XMLAttrs& attrs) { void XMLWriter::writeAttrs(const XMLAttrs& attrs) { for (auto& i : attrs) { output << " " << i.first << "=\""; - for (size_t j = 0; j < i.second.size(); ++j) { - char c = i.second[j]; + for (char c : i.second) { if (c == '"') { output << """; } else if (c == '<') { |